Avoid iterating over all the vuln items once the right one has been found

2015-02-12 18:57:16 +01:00
parent 9f4ca1add7
commit f6dfe0e8dd
1 changed files with 7 additions and 5 deletions
--- a/lib/common/models/wp_item/vulnerable.rb
+++ b/lib/common/models/wp_item/vulnerable.rb
@@ -15,12 +15,14 @@ class WpItem
      json.each do |item|
        asset = item[identifier]

-        if asset
-          asset['vulnerabilities'].each do |vulnerability|
-            vulnerability = Vulnerability.load_from_json_item(vulnerability)
-            vulnerabilities << vulnerability if vulnerable_to?(vulnerability)
-          end
+        next unless asset
+
+        asset['vulnerabilities'].each do |vulnerability|
+          vulnerability = Vulnerability.load_from_json_item(vulnerability)
+          vulnerabilities << vulnerability if vulnerable_to?(vulnerability)
        end
+
+        break # No need to iterate any further
      end

      vulnerabilities