From f6dfe0e8dd4a371a90081926be39f72b89ee2f5b Mon Sep 17 00:00:00 2001 From: erwanlr Date: Thu, 12 Feb 2015 18:57:16 +0100 Subject: [PATCH] Avoid iterating over all the vuln items once the right one has been found --- lib/common/models/wp_item/vulnerable.rb | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/common/models/wp_item/vulnerable.rb b/lib/common/models/wp_item/vulnerable.rb index 37b33aa7..3b7619cf 100755 --- a/lib/common/models/wp_item/vulnerable.rb +++ b/lib/common/models/wp_item/vulnerable.rb @@ -15,12 +15,14 @@ class WpItem json.each do |item| asset = item[identifier] - if asset - asset['vulnerabilities'].each do |vulnerability| - vulnerability = Vulnerability.load_from_json_item(vulnerability) - vulnerabilities << vulnerability if vulnerable_to?(vulnerability) - end + next unless asset + + asset['vulnerabilities'].each do |vulnerability| + vulnerability = Vulnerability.load_from_json_item(vulnerability) + vulnerabilities << vulnerability if vulnerable_to?(vulnerability) end + + break # No need to iterate any further end vulnerabilities