Fixes incorrect detection of a response from the API in some cases

This commit is contained in:
erwanlr
2020-12-15 11:54:59 +01:00
parent 48d363031b
commit 1c30743a11
2 changed files with 36 additions and 1 deletions

View File

@@ -7,7 +7,7 @@ module Typhoeus
#
# @return [ Boolean ]
def from_vuln_api?
effective_url.start_with?(WPScan::DB::VulnApi.uri.to_s) && !effective_url.include?('/status')
effective_url.start_with?(WPScan::DB::VulnApi.uri.to_s) && !effective_url.include?('v3/status')
end
end
end

View File

@@ -0,0 +1,35 @@
# frozen_string_literal: true
describe Typhoeus::Response do
subject(:response) { described_class.new(options) }
let(:options) { { return_code: 200 } }
describe '#from_vuln_api?' do
context 'when response from the Vuln API' do
%w[
https://wpscan.com/api/v3/plugins/wpscan
https://wpscan.com/api/v3/plugins/status-test
https://wpscan.com/api/v3/themes/test
].each do |response_url|
it "returnse false for #{response_url}" do
expect(described_class.new(return_code: 200, effective_url: response_url).from_vuln_api?).to be true
end
end
end
context 'when not a response from the Vuln API' do
%w[
https://wpscan.com/something
http://wp.lab/
https://wp.lab/status
https://wpscan.com/api/v3/status
].each do |response_url|
let(:options) { super().merge(effective_url: response_url) }
it "returns false for #{response_url}" do
expect(described_class.new(return_code: 200, effective_url: response_url).from_vuln_api?).to be false
end
end
end
end
end