Removes the theme version check from the readme, unrealistic scenario - Ref #737
This commit is contained in:
@@ -2,16 +2,8 @@
|
|||||||
|
|
||||||
class WpTheme < WpItem
|
class WpTheme < WpItem
|
||||||
module Versionable
|
module Versionable
|
||||||
|
|
||||||
def version
|
def version
|
||||||
unless @version
|
@version ||= Browser.get(style_url).body[%r{Version:\s*([^\s]+)}i, 1]
|
||||||
@version = Browser.get(style_url).body[%r{Version:\s*([^\s]+)}i, 1]
|
|
||||||
|
|
||||||
# Get Version from readme.txt
|
|
||||||
@version ||= super
|
|
||||||
end
|
|
||||||
@version
|
|
||||||
end
|
end
|
||||||
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -21,26 +21,9 @@ shared_examples 'WpTheme::Versionable' do
|
|||||||
end
|
end
|
||||||
|
|
||||||
context 'when the version is not found' do
|
context 'when the version is not found' do
|
||||||
let(:file) { 'twentyeleven-unknow.css' }
|
it 'returns nil' do
|
||||||
let(:readme_url) { subject.uri.merge('readme.txt').to_s }
|
@file = 'twentyeleven-unknow.css'
|
||||||
|
@expected = nil
|
||||||
context 'from the style_url' do
|
|
||||||
it 'gets it from the readme' do
|
|
||||||
stub_request(:get, readme_url).to_return(status: 200, body: 'Stable Tag: 1.3.4')
|
|
||||||
|
|
||||||
@file = file
|
|
||||||
@expected = '1.3.4'
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
context 'from both style & readme' do
|
|
||||||
it 'returns nil' do
|
|
||||||
allow(subject).to receive_messages(readme_url: readme_url)
|
|
||||||
stub_request(:get, readme_url).to_return(status: 404)
|
|
||||||
|
|
||||||
@file = file
|
|
||||||
@expected = nil
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user