diff --git a/spec/app/controllers/core_spec.rb b/spec/app/controllers/core_spec.rb index 40168e87..b541e450 100644 --- a/spec/app/controllers/core_spec.rb +++ b/spec/app/controllers/core_spec.rb @@ -52,9 +52,10 @@ describe WPScan::Controller::Core do %i[apache iis nginx].each do |server| context "when #{server}" do let(:cli_args) { "#{super()} --server #{server}" } + let(:servers) { [:Apache, nil, :IIS, :Nginx] } it "loads the #{server.capitalize} module and returns :#{server}" do - @stubbed_server = [:Apache, nil, :IIS, :Nginx].sample + @stubbed_server = servers.sample @expected = server == :iis ? :IIS : server.to_s.camelize.to_sym end end diff --git a/spec/lib/target_spec.rb b/spec/lib/target_spec.rb index 9f6fd9a5..aee7b9b3 100644 --- a/spec/lib/target_spec.rb +++ b/spec/lib/target_spec.rb @@ -38,8 +38,10 @@ describe WPScan::Target do %i[wp_version main_theme plugins themes timthumbs config_backups db_exports medias users].each do |method| describe "##{method}" do + let(:methods) { %i[wp_version main_theme] } + before do - return_value = %i[wp_version main_theme].include?(method) ? false : [] + return_value = methods.include?(method) ? false : [] expect(WPScan::Finders.const_get("#{method.to_s.camelize}::Base")) .to receive(:find).with(target, opts).and_return(return_value) diff --git a/wpscan.gemspec b/wpscan.gemspec index 9c7e590f..1bf1dfe9 100644 --- a/wpscan.gemspec +++ b/wpscan.gemspec @@ -29,7 +29,7 @@ Gem::Specification.new do |s| s.add_development_dependency 'rspec', '~> 3.9.0' s.add_development_dependency 'rspec-its', '~> 1.3.0' s.add_development_dependency 'rubocop', '~> 0.90.0' - s.add_development_dependency 'rubocop-performance', '~> 1.7.0' + s.add_development_dependency 'rubocop-performance', '~> 1.8.0' s.add_development_dependency 'simplecov', '~> 0.19.0' s.add_development_dependency 'simplecov-lcov', '~> 0.8.0' s.add_development_dependency 'stackprof', '~> 0.2.12'