garfield/wpscan
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't try to play with the comments in passive detection, just ignore them

Browse Source
This commit is contained in:
erwanlr
2014-09-02 20:42:17 +02:00
parent 96ae8ade5d
commit bd8e6db092
4 changed files with 14 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/common/collections/wp_items/detectable.rb
View File

@@ -83,7 +83,7 @@ class WpItems < Array
results = new(wp_target)
# improves speed
body = remove_base64_images_from_html(Browser.get(wp_target.url).body)
page = Nokogiri::HTML(remove_conditional_comments(body))
page = Nokogiri::HTML(body)
names = []
page.css('link,script,style').each do |tag|

4
lib/common/common_helper.rb
View File

@@ -73,10 +73,6 @@ def add_trailing_slash(url)
url =~ /\/$/ ? url : "#{url}/"
end
def remove_conditional_comments(text)
text.gsub(/\<\!--\[if[^>]+>(.*?)\<\!\[end[^>]+>/im, '\1')
end
# loading the updater
require_files_from_directory(UPDATER_LIB_DIR)
@updater = UpdaterFactory.get_updater(ROOT_DIR)

2
spec/lib/common/collections/wp_items_spec.rb
View File

@@ -18,7 +18,7 @@ describe WpItems do
vulnerable_targets_items: [ WpItem.new(uri, name: 'mr-smith'),
WpItem.new(uri, name: 'neo')],
passive_detection: (1..15).reduce(WpItems.new) { |o, i| o << WpItem.new(uri, name: "detect-me-#{i}") }
passive_detection: (1..13).reduce(WpItems.new) { |o, i| o << WpItem.new(uri, name: "detect-me-#{i}") }
}
end
end

27
spec/samples/common/collections/wp_items/detectable/passive_detection.html
View File

@@ -19,34 +19,27 @@
<script type='text/javascript' src='//wp-content/items/detect-me-5/main.js'></script>
<!--[if lt IE 9]>
<script src="http://example.com/wp-content/items/detect-me-6/assets/js/vendor/html5shiv.js"></script>
<![endif]-->
<!--[if IE 8]>
<link rel="stylesheet" type="text/css" href="https://example.com/wp-content/items/detect-me-7/" />
<![endif]-->
<style type="text/css">
#fancybox-loading.fancybox-ie div {
background: transparent;
filter: AlphaImageLoader(src='http://example.com/wp-content/items/detect-me-8/fancybox/fancy_loading.png', sizingMethod='scale');
filter: AlphaImageLoader(src='http://example.com/wp-content/items/detect-me-6/fancybox/fancy_loading.png', sizingMethod='scale');
}
</style>
<style type="text/css" media="all">
/* <![CDATA[ */
@import url("https://example.com/wp-content/items/detect-me-9/css/plugin.css?ver=1.9.4");
@import url('/wp-content/items/detect-me-10/css/datatables.css?ver=1.9.4');
@import url(/wp-content/items/detect-me-11/css/datatables.css?ver=1.9.4);
@import url(//wp-content/items/detect-me-12/css/datatables.css?ver=1.9.4);
@import url("https://example.com/wp-content/items/detect-me-7/css/plugin.css?ver=1.9.4");
@import url('/wp-content/items/detect-me-8/css/datatables.css?ver=1.9.4');
@import url(/wp-content/items/detect-me-9/css/datatables.css?ver=1.9.4);
@import url(//wp-content/items/detect-me-10/css/datatables.css?ver=1.9.4);
/* ]]> */
</style>
<script type='text/javascript'>
/* <![CDATA[ */
var poll1 = {"ajax_url": "http:\/\/example.com\/wp-content\/items\/detect-me-13\/wp-polls.php", "text_wait": "Please wait a while ..."};
var poll2 = {"ajax_url": "\/wp-content\/items\/detect-me-14\/wp-polls.php", "text_wait": "Please wait a while ..."};
var poll3 = {"ajax_url": "\/\/wp-content\/items\/detect-me-15\/wp-polls.php", "text_wait": "Please wait a while ..."};
var poll1 = {"ajax_url": "http:\/\/example.com\/wp-content\/items\/detect-me-11\/wp-polls.php", "text_wait": "Please wait a while ..."};
var poll2 = {"ajax_url": "\/wp-content\/items\/detect-me-12\/wp-polls.php", "text_wait": "Please wait a while ..."};
var poll3 = {"ajax_url": "\/\/wp-content\/items\/detect-me-13\/wp-polls.php", "text_wait": "Please wait a while ..."};
/* ]]> */
</script>
@@ -59,6 +52,10 @@
//wp-content/items/this-should-not-match/sub.css
src='/wp-content/items/this-should-not-match/sub.css'
<!--[if IE 8]>
<link rel="stylesheet" type="text/css" href="https://example.com/wp-content/items/should-not-match/" />
<![endif]-->
<script type="text/javascript">
var TB_pluginPath = 'http://www.welovebug.com/wp-content/items/js-source';
var TB_config = { 'widget_show_photos': true }