From ab2e368c6fbed064798ff60f969f19e14734f1f3 Mon Sep 17 00:00:00 2001 From: erwanlr Date: Wed, 30 Jul 2014 15:35:55 +0100 Subject: [PATCH] Fixes #625 - Only parse styles when needed --- lib/common/models/wp_theme.rb | 6 ------ lib/common/models/wp_theme/output.rb | 2 ++ spec/lib/common/models/wp_theme_spec.rb | 4 ---- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/common/models/wp_theme.rb b/lib/common/models/wp_theme.rb index 08563f47..81f62a77 100755 --- a/lib/common/models/wp_theme.rb +++ b/lib/common/models/wp_theme.rb @@ -19,12 +19,6 @@ class WpTheme < WpItem def allowed_options; super << :referenced_url end - def initialize(*args) - super(*args) - - parse_style - end - # Sets the @uri # # @param [ URI ] target_base_uri The URI of the wordpress blog diff --git a/lib/common/models/wp_theme/output.rb b/lib/common/models/wp_theme/output.rb index 6aecc31b..00bd6430 100644 --- a/lib/common/models/wp_theme/output.rb +++ b/lib/common/models/wp_theme/output.rb @@ -5,6 +5,8 @@ class WpTheme # @return [ Void ] def additional_output(verbose = false) + parse_style + theme_desc = verbose ? @theme_description : truncate(@theme_description, 100) puts " | Style URL: #{style_url}" puts " | Referenced style.css: #{referenced_url}" if referenced_url && referenced_url != style_url diff --git a/spec/lib/common/models/wp_theme_spec.rb b/spec/lib/common/models/wp_theme_spec.rb index 804acea8..4c0c7613 100644 --- a/spec/lib/common/models/wp_theme_spec.rb +++ b/spec/lib/common/models/wp_theme_spec.rb @@ -3,10 +3,6 @@ require 'spec_helper' describe WpTheme do - before do - stub_request(:get, /.+\/style.css$/).to_return(status: 200) - end - it_behaves_like 'WpTheme::Versionable' it_behaves_like 'WpTheme::Vulnerable' it_behaves_like 'WpItem::Vulnerable' do