From 698f998307443afae9aa4fa18011d68ba8503431 Mon Sep 17 00:00:00 2001 From: Christian Mehlmauer Date: Sat, 22 Jun 2013 21:16:00 +0200 Subject: [PATCH] Fix Issue #231 --- lib/common/common_helper.rb | 4 +++- spec/lib/common/common_helper_spec.rb | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/lib/common/common_helper.rb b/lib/common/common_helper.rb index 42c7cf61..bb73d38b 100644 --- a/lib/common/common_helper.rb +++ b/lib/common/common_helper.rb @@ -118,8 +118,10 @@ def get_equal_string_end(stringarray = ['']) already_found = '' looping = true counter = -1 + # remove nils (# Issue #231) + stringarray = stringarray.compact if stringarray.kind_of? Array and stringarray.length > 1 - base = stringarray[0] + base = stringarray.first while looping character = base[counter, 1] stringarray.each do |s| diff --git a/spec/lib/common/common_helper_spec.rb b/spec/lib/common/common_helper_spec.rb index 1069df16..7b186220 100644 --- a/spec/lib/common/common_helper_spec.rb +++ b/spec/lib/common/common_helper_spec.rb @@ -20,6 +20,21 @@ describe 'common_helper' do @expected = '' end + it 'returns an empty string' do + @input = ['asdf', nil] + @expected = '' + end + + it 'returns an empty string' do + @input = [nil, 'asdf'] + @expected = '' + end + + it 'returns asdf' do + @input = [nil, 'a asdf', nil, 'b asdf'] + @expected = ' asdf' + end + it 'returns asdf' do @input = ['kjh asdf', 'oijr asdf'] @expected = ' asdf'