Only create Versions DF when needed

spec/app/controllers/enumeration_spec.rb

@@ -102,15 +102,6 @@ describe WPScan::Controller::Enumeration do
     end
   end
 
-  describe '#before_scan' do
-    it 'creates the Dynamic Finders' do
-      expect(WPScan::DB::DynamicFinders::Plugin).to receive(:create_versions_finders)
-      expect(WPScan::DB::DynamicFinders::Theme).to receive(:create_versions_finders)
-
-      controller.before_scan
-    end
-  end
-
   describe '#run' do
     context 'when no :enumerate' do
       before do

spec/app/finders/plugin_version_spec.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-# If this file is tested alone (rspec path-to-this-file), then there will be an error about
-# constants not being intilialized. This is due to the Dynamic Finders.
-
 describe WPScan::Finders::PluginVersion::Base do
   subject(:plugin_version) { described_class.new(plugin) }
   let(:plugin)             { WPScan::Model::Plugin.new(slug, target) }
@@ -15,7 +12,7 @@ describe WPScan::Finders::PluginVersion::Base do
       expect(plugin_version.finders.map { |f| f.class.to_s.demodulize }).to match_array @expected
     end
 
-    context 'when no related specific finders' do
+    context 'when no related dynamic finders' do
       let(:slug) { 'spec' }
 
       it 'contains the default finders' do
@@ -25,19 +22,13 @@ describe WPScan::Finders::PluginVersion::Base do
 
     # Dynamic Version Finders are not tested here, they are in
     # spec/lib/finders/dynamic_finder/plugin_versions_spec
-    context 'when specific finders' do
-      let(:specific) do
-        {
-          # None so far
-        }
-      end
-
+    context 'when dynamic finders' do
       WPScan::DB::DynamicFinders::Plugin.versions_finders_configs.each do |plugin_slug, configs|
         context "when #{plugin_slug} plugin" do
           let(:slug) { plugin_slug }
 
-          it 'contains the expected finders (default + specific + the dynamic ones)' do
-            @expected = default_finders + [*specific[plugin_slug]] + configs.keys
+          it 'contains the expected finders (default + the dynamic ones)' do
+            @expected = default_finders + configs.keys
           end
         end
       end

spec/app/finders/theme_version_spec.rb

@@ -13,20 +13,21 @@ describe WPScan::Finders::ThemeVersion::Base do
       expect(theme_version.finders.map { |f| f.class.to_s.demodulize }).to eql @expected
     end
 
-    context 'when no related specific finders' do
+    context 'when no related dynamic finders' do
       it 'contains the default finders' do
         @expected = default_finders
       end
     end
 
-    context 'when specific finders' do
-      {
-      }.each do |theme_slug, specific_finders|
+    # Dynamic Version Finders are not tested here, they are in
+    # spec/lib/finders/dynamic_finder/theme_versions_spec
+    context 'when dynamic finders' do
+      WPScan::DB::DynamicFinders::Theme.versions_finders_configs.each do |theme_slug, configs|
         context "when #{theme_slug} theme" do
           let(:slug) { theme_slug }
 
-          it 'contains the expected finders' do
-            @expected = default_finders + specific_finders
+          it 'contains the expected finders (default + the dynamic ones)' do
+            @expected = default_finders + configs.keys
           end
         end
       end

spec/lib/db/dynamic_finders/plugin_spec.rb

@@ -46,6 +46,17 @@ describe WPScan::DB::DynamicFinders::Plugin do
 
   describe '.create_versions_finders' do
     # handled and tested in spec/lib/finders/dynamic_finders/plugin_version_spec
+
+    describe 'Try to create the finders twice' do
+      # let's just test one slug, no need to test them all
+      let(:slug) { '12-step-meeting-list' }
+
+      it 'does not raise an error when the class already exists' do
+        WPScan::DB::DynamicFinders::Plugin.create_versions_finders(slug)
+
+        expect { WPScan::DB::DynamicFinders::Plugin.create_versions_finders(slug) }.to_not raise_error
+      end
+    end
   end
 
   describe '.version_finder_super_class' do

spec/lib/finders/dynamic_finder/plugin_version_spec.rb

@@ -16,15 +16,9 @@
 
 expected_all = df_expected_all['plugins']
 
-WPScan::DB::DynamicFinders::Plugin.create_versions_finders
-
-describe 'Try to create the finders twice' do
-  it 'does not raise an error when the class already exists' do
-    expect { WPScan::DB::DynamicFinders::Plugin.create_versions_finders }.to_not raise_error
-  end
-end
-
 WPScan::DB::DynamicFinders::Plugin.versions_finders_configs.each do |slug, configs|
+  WPScan::DB::DynamicFinders::Plugin.create_versions_finders(slug)
+
   configs.each do |finder_class, config|
     finder_super_class = config['class'] || finder_class
 

spec/lib/finders/dynamic_finder/theme_version_spec.rb

@@ -16,15 +16,9 @@
 
 expected_all = df_expected_all['themes']
 
-WPScan::DB::DynamicFinders::Theme.create_versions_finders
-
-describe 'Try to create the finders twice' do
-  it 'does not raise an error when the class already exists' do
-    expect { WPScan::DB::DynamicFinders::Theme.create_versions_finders }.to_not raise_error
-  end
-end
-
 WPScan::DB::DynamicFinders::Theme.versions_finders_configs.each do |slug, configs|
+  WPScan::DB::DynamicFinders::Theme.create_versions_finders(slug)
+
   configs.each do |finder_class, config|
     finder_super_class = config['class'] || finder_class