From 37e4461ddd454e7a43596e95e046231016579467 Mon Sep 17 00:00:00 2001 From: erwanlr Date: Mon, 14 Jan 2013 10:51:25 +0100 Subject: [PATCH] Updater cleanup --- lib/updater/updater.rb | 12 +++--------- spec/lib/updater/updater_spec.rb | 2 +- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/updater/updater.rb b/lib/updater/updater.rb index a511605c..9e471cbe 100644 --- a/lib/updater/updater.rb +++ b/lib/updater/updater.rb @@ -27,21 +27,15 @@ class Updater end def is_installed? - raise_must_be_implemented() + raise NotImplementedError end def local_revision_number - raise_must_be_implemented() + raise NotImplementedError end def update - raise_must_be_implemented() - end - - protected - - def raise_must_be_implemented - raise "The method must be implemented" + raise NotImplementedError end end diff --git a/spec/lib/updater/updater_spec.rb b/spec/lib/updater/updater_spec.rb index 038bc386..f2e30b93 100644 --- a/spec/lib/updater/updater_spec.rb +++ b/spec/lib/updater/updater_spec.rb @@ -17,7 +17,7 @@ describe Updater do methods_to_call = [:is_installed?, :update, :local_revision_number] methods_to_call.each do |method_to_call| - expect { test_updater.send(method_to_call) }.to raise_error + expect { test_updater.send(method_to_call) }.to raise_error(NotImplementedError) end end end