diff --git a/lib/common/browser/options.rb b/lib/common/browser/options.rb index 7f761e54..1d7d8994 100644 --- a/lib/common/browser/options.rb +++ b/lib/common/browser/options.rb @@ -82,7 +82,7 @@ class Browser # # @return [ void ] def request_timeout=(timeout) - @request_timeout = timeout + @request_timeout = timeout.to_i end # Sets the connect timeout @@ -90,7 +90,7 @@ class Browser # # @return [ void ] def connect_timeout=(timeout) - @connect_timeout = timeout + @connect_timeout = timeout.to_i end protected diff --git a/spec/lib/common/browser_spec.rb b/spec/lib/common/browser_spec.rb index e82bba6b..8ae81d0d 100644 --- a/spec/lib/common/browser_spec.rb +++ b/spec/lib/common/browser_spec.rb @@ -147,7 +147,6 @@ describe Browser do @expected = default_expectation end - context 'when @proxy' do let(:proxy) { '127.0.0.1:9050' } let(:proxy_expectation) { default_expectation.merge(proxy: proxy) } @@ -166,11 +165,19 @@ describe Browser do end end + context 'when @request_timeout' do + it 'gives an Integer' do + browser.request_timeout = '10' + + @expected = default_expectation.merge(timeout: 10) + end + end + context 'when @basic_auth' do it 'appends the basic_auth' do browser.basic_auth = 'user:pass' @expected = default_expectation.merge( - headers: default_expectation[:headers].merge('Authorization' => 'Basic '+Base64.encode64('user:pass').chomp) + headers: default_expectation[:headers].merge('Authorization' => 'Basic ' + Base64.encode64('user:pass').chomp) ) end end