From 2c0bbe9082d4789f410a69a3849acb3330b9a1c5 Mon Sep 17 00:00:00 2001 From: erwanlr Date: Sun, 2 Feb 2014 15:13:26 +0100 Subject: [PATCH] Updated the version of WebMock required --- Gemfile | 2 +- spec/shared_examples/wp_user/brute_forcable.rb | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Gemfile b/Gemfile index 720943f4..e07c8ae9 100644 --- a/Gemfile +++ b/Gemfile @@ -7,7 +7,7 @@ gem "terminal-table" gem "ruby-progressbar", ">=1.2.0" group :test do - gem "webmock", ">=1.9.3" + gem "webmock", ">=1.17.2" gem "simplecov" gem "rspec", :require => "spec" end diff --git a/spec/shared_examples/wp_user/brute_forcable.rb b/spec/shared_examples/wp_user/brute_forcable.rb index a36e4984..c3985b5b 100644 --- a/spec/shared_examples/wp_user/brute_forcable.rb +++ b/spec/shared_examples/wp_user/brute_forcable.rb @@ -11,7 +11,7 @@ shared_examples 'WpUser::BruteForcable' do describe '#valid_password?' do let(:response) { Typhoeus::Response.new(resp_options) } - let(:resp_options) { {} } + let(:resp_options) { {} } after do wp_user.valid_password?(response, 'password', redirect_url).should == @expected @@ -79,7 +79,8 @@ shared_examples 'WpUser::BruteForcable' do context 'when no password is valid' do before do stub_request(:post, wp_user.login_url). - #with(body: { log: login }). # produces an error : undefined method `split' for {:log=>"someuser", :pwd=>"password1"}:Hash + # with(body: { log: login }). # produces an error : undefined method `split' for {:log=>"someuser", :pwd=>"password1"}:Hash + # Fixed in WebMock 1.17.2, TODO: Modify the specs to_return(body: 'login_error') end @@ -104,6 +105,7 @@ shared_examples 'WpUser::BruteForcable' do # Due to the error with .with(body: { log: login }) above # We can't use it to stub the request for a specific password # So, the first one will be valid + # Fixed in WebMock 1.17.2, TODO: Modify the specs before do stub_request(:post, wp_user.login_url).to_return(status: 302, headers: { 'Location' => redirect_url } )