Implemented Erwan's feedback

lib/common/models/vulnerability.rb

@@ -35,32 +35,6 @@ class Vulnerability
   end
   # :nocov:
 
-  # Create the Vulnerability from the xml_node
-  #
-  # @param [ Nokogiri::XML::Node ] xml_node
-  #
-  # @return [ Vulnerability ]
-  # def self.load_from_xml_node(xml_node)
-  #   references = {}
-  #   refs = xml_node.search('references')
-
-  #   if refs
-  #     references[:url] = refs.search('url').map(&:text)
-  #     references[:cve] = refs.search('cve').map(&:text)
-  #     references[:secunia] = refs.search('secunia').map(&:text)
-  #     references[:osvdb] = refs.search('osvdb').map(&:text)
-  #     references[:metasploit] = refs.search('metasploit').map(&:text)
-  #     references[:exploitdb] = refs.search('exploitdb').map(&:text)
-  #   end
-
-  #   new(
-  #     xml_node.search('title').text,
-  #     xml_node.search('type').text,
-  #     references,
-  #     xml_node.search('fixed_in').text,
-  #   )
-  # end
-
   # Create the Vulnerability from the json_item
   #
   # @param [ Hash ] json_item
@@ -69,12 +43,9 @@ class Vulnerability
   def self.load_from_json_item(json_item)
     references = {}
 
-    references[:url]        = json_item['references'].split(',') if json_item['references']
-    references[:cve]        = json_item['cve'].split(',') if json_item['cve']
-    references[:secunia]    = json_item['secunia'].split(',') if json_item['secunia']
-    references[:osvdb]      = json_item['osvdb'].split(',') if json_item['osvdb']
-    references[:metasploit] = json_item['metasploit'].split(',') if json_item['metasploit']
-    references[:exploitdb]  = json_item['exploitdb'].split(',') if json_item['exploitdb']
+    [:url, :cve, :secunia, :osvdb, :metasploit, :exploitdb].each do |key|
+      references[key] = json_item[key.to_s].split(',') if json_item[key.to_s]
+    end
 
     new(
       json_item['title'],